Skip to content

Removes references to Marmalade in documentation and build process. Closes #626. #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2015
Merged

Removes references to Marmalade in documentation and build process. Closes #626. #627

merged 1 commit into from
May 4, 2015

Conversation

jhenahan
Copy link
Contributor

@jhenahan jhenahan commented May 4, 2015

make all proceeds as normal, save for not generating a tar.

@jhenahan jhenahan mentioned this pull request May 4, 2015
3 tasks
@gracjan
Copy link
Contributor

gracjan commented May 4, 2015

Can you check if haskell-mode-pkg.el is really unused?

Here is what MELPA does with this file:

https://github.com/milkypostman/melpa/blob/aa6427ca25596e81906cdcd79a6616f557fdf3e5/package-build.el#L745

I'm not sure if it sources same information from Commentary sections or from where. But we would like to keep the dependency information about cl-lib.

So can you make sure that haskell-mode-pkg.el is really unused?

@jhenahan
Copy link
Contributor Author

jhenahan commented May 4, 2015

Sorry, my mistake. I didn't realize that MELPA used it.

@gracjan
Copy link
Contributor

gracjan commented May 4, 2015 via email

@jhenahan
Copy link
Contributor Author

jhenahan commented May 4, 2015

According to the API info in the README, it does, for exactly the purpose you mentioned.

@gracjan
Copy link
Contributor

gracjan commented May 4, 2015

OK, in that case haskell-mode-pkg.el needs to stay.

@jhenahan
Copy link
Contributor Author

jhenahan commented May 4, 2015

Already restored, so all should be well.

@gracjan
Copy link
Contributor

gracjan commented May 4, 2015

Can you squash https://github.com/jhenahan/haskell-mode/commit/ecd3fe7d16a1a067f6d536a24dee83dd9d04393b with https://github.com/jhenahan/haskell-mode/commit/10ef4df2e199c87d72a880a843c3c28300a728ac and then force push to the branch like this:

git push origin +feature/no-marmalade-please

(we need clean history on haskell-mode/master).

Drop ELPA generation

Drop the last few tar references

Ditch line about Marmalade from info

Restore pkg.el for MELPA
@jhenahan
Copy link
Contributor Author

jhenahan commented May 4, 2015

Should be all set.

gracjan added a commit that referenced this pull request May 4, 2015
Removes references to Marmalade in documentation and build process.
@gracjan gracjan merged commit 5807ab1 into haskell:master May 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants