Switch from signal to throw/catch in haskell-indentation #672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kuribas: Can you review this pull request? |
|
I originally had throw/catch in my implementation. Someone changed it to signal, I am not sure why? |
|
You can use git blame in haskell-mode repo or git blame in nilcons repo.
|
|
Ok, I see I had error originally, and it was changed to parse-error. Using throw/catch makes sense. It should not be necessary to prefix the haskell-indentation-parse-error symbol, just parse-error would be safe enough. Though you can keep it if you like it. |
gracjan
added a commit
that referenced
this pull request
Jun 1, 2015
Switch from signal to throw/catch in haskell-indentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.