Replace old completion function with new one #733
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gracjan can you merge this? |
|
Give me some more moments, I need to check it out once more.
|
gracjan
added a commit
that referenced
this pull request
Jun 20, 2015
Replace old completion function with new one
This was referenced Jun 21, 2015
|
Thanks for putting this in guys. I'm excited to try company mode now as well. |
|
@lukehoersten I would be happy if you'll find it better than it was before, I'm going to go ahead with company backend soon, and make it even more rocky (: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New method have following features:
dabbrevexpansionOld method does not provided completions for pragma names and words inside comments and strings. Also it fetches completions by synchronous REPL query, this will hang Emacs for a while if REPL is busy. New method fallbacks to dabbrev expansions immediately in this case, though the result is worst. Old method does not provide completions for local names (e.g. defined in
letblocks) and haskell keywords (e.g. "import", "where", etc.), and new method fallbacks to dabbrev expansions in case REPL returned no completions, so it is now possible to auto-complete local names and keywords too. Finally, is there is no haskell session (hence REPL is not available) new method also fallbacks to dabbrev expansions.