Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional candidates limit arg, remove unused item from result #781

Merged
merged 1 commit into from
Jul 27, 2015
Merged

Add optional candidates limit arg, remove unused item from result #781

merged 1 commit into from
Jul 27, 2015

Conversation

geraldus
Copy link
Contributor

+ Add options argument to `haskell-process-get-repl-completions` setting
completion candidates limit
+ Remove unused item from resulting candidates list.  This item is not
completion itself but unused part of input string (see issue #776 for
more details).
@geraldus
Copy link
Contributor Author

@gracjan updated

gracjan added a commit that referenced this pull request Jul 27, 2015
Add optional candidates limit arg, remove unused item from result
@gracjan gracjan merged commit 2ad392f into haskell:master Jul 27, 2015
@geraldus geraldus deleted the get-repl-completions-fix branch July 28, 2015 07:37
@vwyu
Copy link
Contributor

vwyu commented Aug 10, 2015

It seems that this change introduces a problem. Here is what I get by typing some import expressions after λ> and pressing tab:

  1. Pressing tab after "import Co" makes it "import CoCo".
  2. Pressing tab after "import Con" makes it "import ConControl."

It looks like part of the string is repeated. I would expect the following behavior:

Expected 1) Pressing tab after "import Co" shouldn't change it.
Expected 2) Pressing tab after "import Con" should make it "import Control."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants