Add unused string in completions as well. #810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gracjan
added a commit
that referenced
this pull request
Aug 10, 2015
Add unused string in completions as well.
|
For now accepted. There is something fishy going on with these functions though. Their return value should follow this protocol: http://www.gnu.org/software/emacs/manual/html_node/elisp/Completion-in-Buffers.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that the issue #787 might be due to the "unused string" (h1) being not in completions list (cs). This commit reverts part of the commit f0466a2 back to the earlier version, where the unused string (h1) is placed at beginning of the completions list (cs).