-
Notifications
You must be signed in to change notification settings - Fork 347
Fix hoogle lookup from local servers #834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Use a better way to check if the hoogle process is alive: Instead of checking if the corresponding buffer-name is an alive process, store the process handle in a global variable and check that. The problem is that when using 'hoogle-lookup-from-local' without any hoogle server running, a new local hoogle server is started, but the code fails to recognize that server is running and instead repeatedly reports that the server is not running offering to start it.
@sheyll: Have you had time to look into this? |
Start "hoogle" directly instead of going through "/bin/sh -c ..." as suggested by 'gracjan' here: [951e1bc#commitcomment-13024225]
@gracjan is this ok now? I could only test on linux |
Fix hoogle lookup from local servers
Great, thanks. The functionality around hoogle and hayoo could use refactoring and be merged. Can you look into improving code there? |
I think you need to pass |
Not strictly related to this PR but I'm curious to why it's not there already because local hoogle links are broken for me otherwise... |
I do not understand... What file links? |
Sorry, when running hoogle with
Without the I was just wondering if it makes to add |
I still do not get it.
If hoogle produces wrong kind of links that make hoogle unusable then that
is a bug in hoogle and should be fixed there, shouldn't it?
|
All I need is the ability to pass |
Use a better way to check if the hoogle process is alive: Instead of
checking if the corresponding buffer-name is an alive process, store the
process handle in a global variable and check that.
The problem is that when using 'hoogle-lookup-from-local' without any
hoogle server running, a new local hoogle server is started, but the
code fails to recognize that server is running and instead repeatedly
reports that the server is not running offering to start it.