Don't spuriously set mark on xref push #865
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes #863, whereby jumping to the definition of a symbol in the same file was incorrectly activating the mark and region. This commit also simplifies the original code, since the initial position marker can simply be passed to xref-push-marker-stack. (The haskell-compat shim for that function is also fixed here accordingly.)
gracjan
added a commit
that referenced
this pull request
Sep 12, 2015
Don't spuriously set mark on xref push
|
Nice. So I have learned something about xref-push today. Thanks. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #863, whereby jumping to the definition of a symbol in the
same file was incorrectly activating the mark and region. This commit
also simplifies the original code, since the initial position marker can
simply be passed to xref-push-marker-stack. (The haskell-compat shim for
that function is also fixed here accordingly.)