Use backspace to move to the previous indentation position in haskell-indentation #866
Conversation
unindent instead of deleting a single character. This restores the old behaviour mentioned in `haskell-indentation-mode`'s docstring. See haskell#500
|
Test cases are crucial for quality engineering. We do not want your functionality to accidentally stop working in a couple of weeks annoying everybody. We try to roughly follow the process described in Pull request checklist. Please add a test case. |
|
OK, do you have an example of a test that tests interactive editing, that I can base my test cases on? I'd like the test to enter text, position the cursor, press backspace, and then check what has been deleted and where the cursor ends up. |
|
haskell-indentation-tests.el has relevant code in the macro. You can extract this into other function. |
|
I've looked at |
|
That is the kind of tests that are done currently. Can you add different kind of tests that will test interactive functions? We have more than one interactive function to test. |
gracjan
changed the title
|
@gergoerdi very useful fix indeed ! I don't think I feel confident enough to add the test case (as you said there is no template/file for this kind of tests yet) |
|
I've added example tests in #994. You need to create a similar test. |
|
I've been running with this commit for a while and I find it very confusing. Is this really what people want? |
|
I don't feel strongly either way. I often want |
|
I've run with this functionality for a month now and so far learned to fear my Backspace. This is not going in. |
|
That echoes my experience with such functionality elsewhere. |
This patch restores the "backspace on first colum unindents" functionality.
I wasn't able to find any existing tests for interactive indentation commands so I didn't bother.