Skip to content

Remove horizontal whitespace based smart indentation mode haskell-simple-indent #958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2015
Merged

Remove horizontal whitespace based smart indentation mode haskell-simple-indent #958

merged 1 commit into from
Dec 17, 2015

Conversation

gracjan
Copy link
Contributor

@gracjan gracjan commented Oct 26, 2015

Rationale:

  • haskell-indentation-mode became reliable enough for general use
  • haskell-indentation-mode lost its magic and now has a nice predictable behavior
  • simple indent despite its name is also a 'smart' mode with surprising behavior
  • people think that simple indent does constant space indentation and this is not true, simple indent tries to be smart
  • it relies on whitespace between tokens and Haskell defines token boundaries in a different way
  • community effort should be more focused

@ivan-m
Copy link
Contributor

ivan-m commented Oct 27, 2015

Any particular reason why? There might be people that prefer not to use a "smart" indentation mode and just manually indent/un-indent.

@gracjan
Copy link
Contributor Author

gracjan commented Oct 27, 2015

@ivan-m: I updated my comment to state the rationale for the move. Are you using this mode yourself or were you stating a theoretical question?

@ivan-m
Copy link
Contributor

ivan-m commented Oct 27, 2015

Just theoretical. I'm happy enough with your justifications (I didn't realise it tried to be smart, and thought it just did indent/un-indent).

@gracjan gracjan changed the title Remove haskell-simple-indent Remove horizontal whitespace based smart indentation mode haskell-simple-indent Oct 30, 2015
gracjan added a commit that referenced this pull request Dec 17, 2015
Remove horizontal whitespace based smart indentation mode haskell-simple-indent
@gracjan gracjan merged commit c5987ad into haskell:master Dec 17, 2015
@gracjan gracjan mentioned this pull request Mar 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants