Truncate multi-line messages less aggressively #990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When preparing multiline messages for the minibuffer, unwrap onto one line and only truncate as much as necessary. Previously, we showed the first line and only a small part of the second. closes haskell#988
gracjan
changed the title
gracjan
added a commit
that referenced
this pull request
Nov 13, 2015
Truncate multi-line messages less aggressively
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When preparing multiline messages for the minibuffer, unwrap onto one line
and only truncate as much as necessary. Previously, we showed the first
line and only a small part of the second.
closes #988
This does the right thing even with proportional fonts. It should DTRT with wide chars and combining chars, but I haven't verified that.
I looked at all the calls to
haskell-mode-message-line, and I think it's reasonable to have them all use this new truncation behavior, but I'd appreciate someone double-checking that.