Add functions for coverting between annotated and unannotated Docs. #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `docToUnitDoc :: Doc -> Ann.Doc ()` - `unitDocToAnnotatedDoc :: Ann.Doc () -> Ann.Doc a` These two functions together allow you to combine together annotated and unannotated documents. In particular, it lets you embed a unannotated `Doc` inside another, annotated `Doc a` of arbitrary annotation type.
|
It indeed makes sense to have these. Thanks! I'll leave this open now, I have to think about naming. Please ping me if nothing happens in two weeks. |
|
@phadej, friendly ping? |
|
@phadej May I ask the status of this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docToUnitDoc :: Doc -> Ann.Doc ()unitDocToAnnotatedDoc :: Ann.Doc () -> Ann.Doc aThese two functions together allow you to combine together annotated
and unannotated documents. In particular, it lets you embed a unannotated
Docinside another, annotated
Doc aof arbitrary annotation type.