Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to base < 4.21 (to support GHC 9.10) #316

Merged
merged 1 commit into from
May 16, 2024

Conversation

tomjaguarpaw
Copy link
Member

I don't know what we should do about testing this, since haskell-actions doesn't have 9.10 yet. Should we wait for it to do so?

(Relatedly, I'm surprised that, since process is a boot library, that GHC could even release without this bump having already been performed. Maybe GHC just doesn't look at cabal version bounds at all.)

@tomjaguarpaw tomjaguarpaw requested a review from bgamari May 11, 2024 17:17
@tomjaguarpaw
Copy link
Member Author

GHC 9.10 is now available in haskell-actions so I plan to merge this change to CI and make a Hackage revision.

@tomjaguarpaw tomjaguarpaw merged commit d74bba2 into haskell:master May 16, 2024
41 checks passed
@tomjaguarpaw tomjaguarpaw deleted the 9.10 branch May 16, 2024 07:56
@tomjaguarpaw
Copy link
Member Author

@bgamari
Copy link
Contributor

bgamari commented May 16, 2024

@tomjaguarpaw, in the case of strict version bounds bumps it's not uncommon for GHC to carry patches locally performing the bounds bumps. This has historically been necessary since some core library authors are reluctant to merge bounds bumps until the GHC release has been made final, placing us in a bit of a chicken-egg situation.

@tomjaguarpaw
Copy link
Member Author

That makes sense. Thanks for the explanation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants