Optimize the implementation of Data.Text.concat #551
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids allocating intermediate lists. Does not make any change to the algorithm.
Fixes #550.
As mentioned in #550 (comment),
concat
can alternately be implemented using a strategy which makes one pass over the list, filling and growing a buffer. This PR only optimizes the existing implementation and does not change to this strategy.Output of
cabal run text-benchmarks -- -p '$4 == "concat" && $5 == "Text"' +RTS -T
with GHC 9.6.3:Before:
After: