Skip to content

HLS will not update to latest if have local in PATH #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
soiamsoNG opened this issue Sep 16, 2021 · 4 comments
Closed

HLS will not update to latest if have local in PATH #456

soiamsoNG opened this issue Sep 16, 2021 · 4 comments
Labels
type: enhancement An enhancement to an already existing feature

Comments

@soiamsoNG
Copy link
Contributor

HLS will not update to latest if have local in PATH

if we could prompt and let user to select the behavior

@jneira
Copy link
Member

jneira commented Sep 19, 2021

hi, thanks for the suggestion. I think it would be disturbing for users wanting to use an older version of hls in PATH being prompted to install the new one. So it should be a configuration option, maybe preserving the actual behaviour as default.

@jneira jneira added the type: enhancement An enhancement to an already existing feature label Sep 19, 2021
@soiamsoNG
Copy link
Contributor Author

Sorry mistake close, I will write a PR, because keep-up-to-date behavior, ignore when have HLS in local PATH (even Server Executable Path not set)

@jneira
Copy link
Member

jneira commented Sep 20, 2021

hmm thanks, but you have to consider the extension prefers the executable in PATH over the downloaded ones

@fendor
Copy link
Collaborator

fendor commented Dec 5, 2022

irrelevant now, HLS binaries are managed by ghcup now

@fendor fendor closed this as completed Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement An enhancement to an already existing feature
Projects
None yet
Development

No branches or pull requests

3 participants