Skip to content

Check updateBehavior before find local excutable in PATH #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Check updateBehavior before find local excutable in PATH #461

wants to merge 2 commits into from

Conversation

soiamsoNG
Copy link
Contributor

for #456

ManualExcuteble will check first as before.
if updateBehavior keep-up-to-date set, will prefer check/download HLS release rather than local PATH

@soiamsoNG
Export Type UpdateBehavior
979f9ca 
Export Type UpdateBehavior
@soiamsoNG
Check updateBehaviour before findLocalServer
97ac6a7 
Check updateBehaviour before findLocalServer
jneira
jneira requested changes Sep 20, 2021
View reviewed changes
Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi, thanks for the pr but I would add a new config option keep up to date ignoring PATH to minimize impact in actual behaviour, keeping the actual option as default

@jneira jneira mentioned this pull request Nov 17, 2021
Closed
@soiamsoNG soiamsoNG mentioned this pull request Mar 2, 2022
Merged
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jneira jneira jneira requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soiamsoNG @jneira