Skip to content

Add ignorePATH option #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 4, 2022
Merged

Add ignorePATH option #534

merged 2 commits into from
Mar 4, 2022

Conversation

soiamsoNG
Copy link
Contributor

Add option to ignore haskell-language-server on PATH
relate to #461 #500

fendor
fendor requested changes Mar 2, 2022
View reviewed changes
Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this feature! some minor comments open for discussion :)

fendor
fendor approved these changes Mar 2, 2022
View reviewed changes
Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@fendor fendor requested a review from jneira March 2, 2022 12:36
@jneira jneira removed their request for review March 4, 2022 11:54
@jneira
Copy link
Member

jneira commented Mar 4, 2022

feel free to merge when you consider

@fendor fendor merged commit bf8b6c0 into haskell:master Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fendor fendor fendor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@soiamsoNG @jneira @fendor