Correct signatures for FinalizerPtrs
#57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amesgen
force-pushed
the
wasm
branch
2 times, most recently
from
6a9ce44 to
99fc84d
Compare
|
@amesgen could you please rebase and add CI job? It's fine to modify - name: Build
run: |
rm -f cabal.project
cat > cabal.project <<EOF
packages: .
if os(wasi)
-- https://github.com/haskellari/splitmix/pull/73
source-repository-package
type: git
location: https://github.com/amesgen/splitmix
tag: ebd790e992a83fe1b16b6182677106295d9afba2
EOF
wasm32-wasi-cabal build all -f+bundled-c-zlib |
Bodigrim
reviewed
Oct 25, 2023
| @@ -101,7 +101,10 @@ library | |||
| build-tools: hsc2hs >= 0.67 && < 0.69 | |||
| -- GHC 7 ships hsc2hs-0.67 | |||
|
|
|||
| includes: zlib.h | |||
| includes: zlib.h hs-zlib.h | |||
| install-includes: hs-zlib.h | |||
There was a problem hiding this comment.
Could you please add a comment what's the deal with both includes and install-includes? I always forget the difference.
| @@ -0,0 +1,8 @@ | |||
| #ifndef HS_ZLIB_EXTRAS | |||
| #define HS_ZLIB_EXTRAS | |||
There was a problem hiding this comment.
It is an include guard. Alternatively, this could be replaced with #pragma once (with very(?) slightly reduced portability).
cbits-extra/hs-zlib.c
Outdated
| @@ -0,0 +1,9 @@ | |||
| #include "hs-zlib.h" | |||
|
|
|||
| void hsInflateEnd(z_streamp strm) { | |||
There was a problem hiding this comment.
Let's mangle names even more, like _hs_zlib_inflateEnd or something.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have the signature
in contrast to
so we have a return type mismatch. This doesn't seem to matter on most platforms, but causes errors for WASM/WASI.
Also adds a CI job for GHC WASM/WASI 9.6 and 9.8.