Deprecate Math.NumberTheory.Powers #6
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been long suspecting that
{integer,natural}{,Word}Powerfunctions are no better than(^)in contemporary GHC andbase. Several months ago I have written benchmarks (branchwip-benchmarks). Results (https://github.com/Bodigrim/integer-logarithms/blob/wip-benchmarks/benchmark/results.csv) show that:integerPowerappears slower or faster than(^). Typically it is 10% faster for exponents2^n, 10% slower for exponents2^n-1and 30%-60% slower for exponents2^n+1.Naturalit appears that(^)is almost always faster (up to 60%) thannaturalPower.Taking into account such evidence, I find reasonable to deprecate
{integer,natural}{,Word}Powerand use(^)instead. I have already done it inarithmoi, without any negative consequences.