Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 404 friendlier #407

Merged
merged 2 commits into from
Jun 11, 2023
Merged

Make 404 friendlier #407

merged 2 commits into from
Jun 11, 2023

Conversation

david-christiansen
Copy link
Contributor

Update the 404 page to use some undocumented features of the GitHub "create page" feature to automatically provide the right filename and a template.

It seems that the "create page" query strings have worked this way for at least a couple of years now, and it'll be easy enough to tweak the page again if it changes.

Update the 404 page to use some undocumented features of the GitHub
"create page" feature to automatically provide the right filename and
a template.
@david-christiansen
Copy link
Contributor Author

@david-christiansen
Copy link
Contributor Author

I just had a chat in person with Sam D., and he's on board with this update as being sufficient to address his concerns right now.

@BinderDavid BinderDavid self-requested a review June 11, 2023 12:22
@david-christiansen david-christiansen merged commit 255f8c8 into main Jun 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants