-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
complete theme injection #1
complete theme injection #1
Conversation
If it works for you. Or actually, I could move my branch to theme-ui repo to keep all conversation there. |
BTW. All CSS object properties are optional ( |
@nandorojo, it's impossible to change base branch of the PR. Let's keep it here, I'll try to merge anything swiftly so we can still be focused on system-ui/theme-ui repo and use this branch just to consolidate the code. |
@hasparus Looks like my tests are failing in the Does anything stand out to you as the reason for the errors here so far? |
I think we can merge it with failing tests. I'll take a look at them tonight. |
I'm giving you access to this fork so you can merge whenever you're ready. |
Appreciate that, thanks! |
@hasparus is this the right approach to adding more scales here?
Note, I haven't added any comments yet, but if this is the right path, then I could do that next.
cc @cmaycumber
PS I have this set to merge into @hasparus's branch, not sure if that's the right move or not. I haven't done a PR pointed at another PR before.