Fix: Onboarding - Detect german language keyboard layouts

[f-rakete]

InputLanguageCheckDiffers() only checks agains intput language, but the input language might be non-german and the keyboard layout still is.

fixed with info from: https://stackoverflow.com/a/27747405

[amadeo-alex]

Hello and thank you for the PR!
We've attempted something like this where if any of the installed languages (InstalledInputLanguages) are "german", the popup is shown - https://github.com/hass-agent/HASS.Agent/pull/74/files
The added code checks for "CurrentInputLanguage" - did you had a case where the InstalledInputLanguages check failed and the popup was not shown despite german KB layout being there?

[f-rakete]

Hello and thank you for the PR!
We've attempted something like this where if any of the installed languages (InstalledInputLanguages) are "german", the popup is shown - https://github.com/hass-agent/HASS.Agent/pull/74/files
The added code checks for "CurrentInputLanguage" - did you had a case where the InstalledInputLanguages check failed and the popup was not shown despite german KB layout being there?

That's why I'm doing the pull request - i have win11 with English language but german keyboard layout and it didn't notify me 🙃

[amadeo-alex]

I did some tests and looks like it won't be that easy :D
The name (so for example the check for "German" that you did) depends on a system locale - I have a windows with a polish display language and two keyboard layouts, PL & ENG-UK. When I change the KB layout to ENG-UK one,
"InputLanguage.CurrentInputLanguage.LayoutName" resolves to "Zjednoczone Królestwo" which is basically "United Kingdom".

[amadeo-alex]

Even better, if I take a POL-PLP input culture info object and compare it to POL-DE object, they are "equal" :)
It just simply does name check and both have pl-PL name for some unknown to me reason.

[amadeo-alex]

dotnet/winforms#8439
So yeah, it was merged to Winforms for .net 8 preview if I understand correctly...

[amadeo-alex]

I just had a nice head first dive into keyboard layouts on windows and oh boi, that's gonna be a nice adventure.
We'll basically need to recreate the code from the fix and then modify it a bit...
Sleep first tho :D

[amadeo-alex]

Would you be so kind to test this branch - https://github.com/amadeo-alex/HASS.Agent/tree/fix-german-keyboard2 ?

[f-rakete]

Would you be so kind to test this branch - https://github.com/amadeo-alex/HASS.Agent/tree/fix-german-keyboard2 ?

my InputLanguage.CurrentInputLanguage.Handle is 0x0000000004072000 so KnownOkInputLanguage doesn't catch it

keyboardLayoutIdName is "00000407"

so this check KnownNotOkKeyboardLayouts[keyboardLayoutLanguageId] finds it

summary:
that branch works on my machine 🚀