Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UnRAR 7 compatibility #188

Merged
merged 2 commits into from
Jun 5, 2024
Merged

Conversation

krvi
Copy link
Contributor

@krvi krvi commented Jun 3, 2024

Description:

I've been using rar2fs for years, getting it from Entware. After upgrading libunrar to 6.2.12 a couple of months ago, rar2fs stopped working for me, so I had to revert back to 6.1.3.

I noticed that UnRAR started using new types from C++11 and removed the NM constant. I looked into #186 and, over the past few days, refreshed my knowledge of C++ to address this issue.

Changes Made:

  • Adapted dllext.cpp to work with new types introduced in UnRAR 7
    • In those cases, removed dependencies on the NM constant.

Testing:

  • Compiled without warnings with unrar-7.0.9.
    • Tested with unrar-7.0.9 on a multi-volume archive with filenames containing 4-byte UTF-8 characters. Also tested on a few more common / UTF-8-named archives and confirmed they worked as expected.
  • Compiles without warnings with unrar-6.1.3, however, I have not tested it with this version.

@hasse69
Copy link
Owner

hasse69 commented Jun 4, 2024

Thanks for the patches! Would it be possible for you to test the backwards compatibility before we merge this?

@hasse69 hasse69 merged commit d1d31f4 into hasse69:master Jun 5, 2024
@krvi krvi deleted the unrar7compatibility branch June 9, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants