Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⬆️ Upgrades UniFi Network Application to 7.2.92 #375

Merged
merged 4 commits into from
Aug 21, 2022
Merged

⬆️ Upgrades UniFi Network Application to 7.2.92 #375

merged 4 commits into from
Aug 21, 2022

Conversation

hip4
Copy link
Contributor

@hip4 hip4 commented Aug 9, 2022

@rsnodgrass
Copy link
Contributor

Thank you @hip4 and @frenck!

@frenck
Copy link
Member

frenck commented Aug 9, 2022

Thanks, but please avoid the pinging, it's another notification in my inbox unneeded. Thanks 👍

rsnodgrass
rsnodgrass reviewed Aug 9, 2022
View reviewed changes
Copy link
Contributor

@rsnodgrass rsnodgrass left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that is the correct official release 7.2.92 version URL.

@numero-trey
Copy link

Is there something blocking this merge? This is a big release because it finally adds local DNS entries!

@rsnodgrass
Copy link
Contributor

Is there something blocking this merge? This is a big release because it finally adds local DNS entries!

Ideally, there would be a process to expedite releases or allow multiple parties to be able to review/publish. If this had significant security patches, this delay would be a huge issue. IMO, there should also be a path for being able to have Release Candidates/Betas available to those who want them.

@frenck
Copy link
Member

frenck commented Aug 20, 2022 •
edited
Loading

If this had significant security patches, this delay would be a huge issue.

Just that is taken care of, however this is not the case now, so no need to rush or prioritize this right now.

IMO, there should also be a path for being able to have Release Candidates/Betas available to those who want them.

If you want that, than this add-on is not for you.

@frenck
Copy link
Member

frenck commented Aug 20, 2022

Is there something blocking this merge? This is a big release because it finally adds local DNS entries!

It awaits time allocation for review and testing across a bunch of device ensure it works. Please have patience.

@frenck frenck added dependencies Upgrade or downgrade of project dependencies. minor This PR causes a minor version bump in the version number. labels Aug 21, 2022
@frenck
Copy link
Member

frenck commented Aug 21, 2022

Thanks, @hip4 👍

@frenck frenck changed the title Feature/update to 7.2.92 ⬆️ Upgrades UniFi Network Application to 7.2.92 Aug 21, 2022
@frenck frenck merged commit b6fce84 into hassio-addons:main Aug 21, 2022
@frenck
Copy link
Member

frenck commented Aug 21, 2022

Just a small heads up on the reasoning that I haven't shipped this yet at this point: One of the systems I use for testing shows a data migration issue using the edge build. I'm not sure if this is a one-off issue or a structural issue. Looking into it.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 23, 2022
@frenck
Copy link
Member

frenck commented Sep 15, 2022

I finally figured out what the issue was. Sorry for de delay as I have been on Holiday as well.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rsnodgrass rsnodgrass rsnodgrass left review comments

@frenck frenck frenck approved these changes

Assignees
No one assigned
Labels
dependencies Upgrade or downgrade of project dependencies. minor This PR causes a minor version bump in the version number.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hip4 @rsnodgrass @frenck @numero-trey