Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Upgrades UniFi Network Application to 8.0.24 #469

Merged
merged 2 commits into from
Dec 28, 2023
Merged

⬆️ Upgrades UniFi Network Application to 8.0.24 #469

merged 2 commits into from
Dec 28, 2023

Conversation

renewoensdregt
Copy link
Contributor

Bumped version to 8.0.24

Proposed Changes

version bumped to 8.0.24

Related Issues

(Github link to related issues or pull requests)

Bumped version to 8.0.24
@renewoensdregt
Copy link
Contributor Author

Not sure why it fails on binutils... it is the same dockerfile as the current main version where the same binutils version is being used...

@tjorim
Copy link

tjorim commented Dec 16, 2023

Did you even test this PR before opening it? E.g. run a docker build on your local system? The package was updated a few weeks ago. Please check the Ubuntu packages.

@renewoensdregt
Copy link
Contributor Author

Thanks! No sorry and working on that now. I'm not an expert so learning as I go. As the current main branch works, with all the same I expected it would work, but not.

Will try to fix and run a build locally until I get it working. Any suggestions on how to find the right package version would be helpful.

@renewoensdregt
Copy link
Contributor Author

renewoensdregt commented Dec 16, 2023

Ok. fixed it. Now it compiles OK. Version was indeed changed, so now OK.
I see it only fails now for the labels, but I think I cannot update that. Last time Frenck updated those and I see he does this every time, so I don´t think I can do that.

@renewoensdregt
Copy link
Contributor Author

@frenck sorry to tag you directly, but is there anything pending for me to ensure this pull request is approved?

@frenck
Copy link
Member

frenck commented Dec 20, 2023

I am few day out of office atm.

@frenck frenck added the dependencies Upgrade or downgrade of project dependencies. label Dec 28, 2023
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @renewoensdregt 👍

../Frenck

@frenck frenck merged commit 5265999 into hassio-addons:main Dec 28, 2023
10 of 11 checks passed
@frenck frenck changed the title Version update to 8.0.24 ⬆️ Upgrades UniFi Network Application to 8.0.24 Dec 28, 2023
@renewoensdregt renewoensdregt deleted the Update-to-8.0.24 branch December 29, 2023 10:40
@github-actions github-actions bot locked and limited conversation to collaborators Dec 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Upgrade or downgrade of project dependencies.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants