build: Exclude generated Tutor configuration from flake8 tests #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until Tutor 17, just enabling a plugin with "tutor plugin enable" would not recreate the configuration, meaning the tests/tutor-sandbox/env directory would remain empty. As of overhangio/tutor#957, however, "tutor plugin enable" does automatically also run "tutor config save", generating a full Tutor configuration. This means that unless configured otherwise, with Tutor 17 our flake8 checks would test code generated by Tutor, rather than just that generated by our plugin. Thus, to make our tests not break once we bump our dependencies to support Tutor 17, exclude the tests/tutor-sandbox/env checks from flake8.
fghaas
changed the title
mrtmm
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until Tutor 17, just enabling a plugin with
tutor plugin enablewould not recreate the configuration, meaning thetests/tutor-sandbox/envdirectory would remain empty.As of overhangio/tutor#957, however,
tutor plugin enabledoes automatically also runtutor config save, generating a full Tutor configuration.This means that unless configured otherwise, with Tutor 17 our flake8 checks would test code generated by Tutor, rather than just that generated by our plugin.
Thus, to make our tests not break once we bump our dependencies to support Tutor 17, exclude the
tests/tutor-sandbox/envchecks from flake8.