Support raw json fields #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hgiasac PTAL, I'd be very grateful to have this accepted. |
|
LGTM. Let's solve @bclermont comments, then we can merge this |
|
@hgiasac @bclermont sorry, I missed your review. Will fix this today or tomorrow. |
|
Made changes. Unfortunately I can't re-request review. @bclermont @hgiasac |
By specifing json.RawMessage as a field type in a query raw json fields can be queried and returned. This is a copy of cameronbrunner@415210cccf58be084de7233cac65d8732ac99216V
|
Also needed to adjust error message to meet #8 requirements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a port of @cameronbrunner fix to the original repo. See shurcooL#41
It also contains fixes to
quest_test.go