Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verify if curl respose is 200 in cli download script #1871

Closed
martimatix opened this issue Mar 26, 2019 · 4 comments
Closed

verify if curl respose is 200 in cli download script #1871

martimatix opened this issue Mar 26, 2019 · 4 comments
Assignees
Labels
c/cli Related to CLI e/quickfix can be wrapped up in few hours good first issue Good for newcomers help wanted Good candidate for contribution. Community help wanted! p/medium non-urgent issues/features that are candidates for being included in one of the upcoming sprints

Comments

@martimatix
Copy link

Following the instructions on Installing Hasura CLI is failing on OS X.

Steps to reproduce:

  1. Below is the shell output of following the instructions form the above page
$ sudo curl -L https://github.com/hasura/graphql-engine/raw/master/cli/get.sh | bash

Password:
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   139  100   139    0     0     21      0  0:00:06  0:00:06 --:--:--    39
100  3476  100  3476    0     0    424      0  0:00:08  0:00:08 --:--:--  6263
--> Getting latest version...
--> Latest version is v1.0.0-alpha41
--> Downloading hasura for darwin-amd64 to /tmp/cli-hasura-darwin-amd64
######################################################################## 100.0%
--> Download complete!
--> Moving cli from /tmp/cli-hasura-darwin-amd64 to /usr/local/bin
-->
--> hasura cli installed to /usr/local/bin
-->
/usr/local/bin/hasura: line 1: Not: command not found
  1. Running $ cat /usr/local/bin/hasura outputs the following:
Not Found
@shahidhk
Copy link
Member

Hello @martimatix. We were unable to reproduce this on a Mac. Can you try again and if it happens again, give us more details?

@shahidhk shahidhk added c/cli Related to CLI support/needs-more-info Needs more details/info/repro instructions labels Mar 27, 2019
@martimatix
Copy link
Author

It's working now.

Before I close this issue, is it worth raising an issue about not creating a file if the download failed? For example, in case of download failure, the installer could say something like "Something went wrong with installing Hasura CLI -- try again later."

Getting a "Not Found" file was not a great first experience of using Hasura CLI.

@shahidhk
Copy link
Member

Indeed, we could verify the curl command gets a 200 response.

@shahidhk shahidhk changed the title Installing Hasura CLI on Mac OS failing verify if curl respose is 200 in cli download script Jul 10, 2019
@shahidhk
Copy link
Member

Changed the scope of issue to check if a 200 response is received while downloading the CLI

@shahidhk shahidhk added e/quickfix can be wrapped up in few hours good first issue Good for newcomers help wanted Good candidate for contribution. Community help wanted! p/medium non-urgent issues/features that are candidates for being included in one of the upcoming sprints and removed support/needs-more-info Needs more details/info/repro instructions labels Jul 10, 2019
polRk pushed a commit to polRk/graphql-engine that referenced this issue Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/cli Related to CLI e/quickfix can be wrapped up in few hours good first issue Good for newcomers help wanted Good candidate for contribution. Community help wanted! p/medium non-urgent issues/features that are candidates for being included in one of the upcoming sprints
Projects
None yet
Development

No branches or pull requests

2 participants