Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gather usage telemetry data for cache #3552

Closed
jberryman opened this issue Dec 17, 2019 · 0 comments
Closed

Gather usage telemetry data for cache #3552

jberryman opened this issue Dec 17, 2019 · 0 comments
Assignees
Labels
c/server Related to server p/medium non-urgent issues/features that are candidates for being included in one of the upcoming sprints s/wip Status: This issue is a work in progress

Comments

@jberryman
Copy link
Collaborator

See action items in #3530

@jberryman jberryman self-assigned this Dec 17, 2019
@marionschleifer marionschleifer added the c/server Related to server label Dec 17, 2019
@lexi-lambda lexi-lambda added the p/medium non-urgent issues/features that are candidates for being included in one of the upcoming sprints label Dec 17, 2019
@jberryman jberryman added the s/wip Status: This issue is a work in progress label Jan 2, 2020
jberryman added a commit to jberryman/graphql-engine that referenced this issue Jan 3, 2020
…3552

We upload a set of accumulating timers and counters to track service
time for different types of operations, across several dimensions (e.g.
did we hit the plan cache, was a remote involved, etc.)
jberryman added a commit to jberryman/graphql-engine that referenced this issue Jan 6, 2020
…3552

We upload a set of accumulating timers and counters to track service
time for different types of operations, across several dimensions (e.g.
did we hit the plan cache, was a remote involved, etc.)

Introduce time-units library. Some issues I have with this lib:
 - loses precision when converting, for no good reason
 - maximumum us resolution for no good reason
 - not part of an existing time lib or algebra of time (see e.g.
   NominalDiffTime)
jberryman added a commit to jberryman/graphql-engine that referenced this issue Jan 17, 2020
…3552

We upload a set of accumulating timers and counters to track service
time for different types of operations, across several dimensions (e.g.
did we hit the plan cache, was a remote involved, etc.)
jberryman added a commit to jberryman/graphql-engine that referenced this issue Jan 21, 2020
…3552

We upload a set of accumulating timers and counters to track service
time for different types of operations, across several dimensions (e.g.
did we hit the plan cache, was a remote involved, etc.)
jberryman added a commit to jberryman/graphql-engine that referenced this issue Jan 23, 2020
…3552

We upload a set of accumulating timers and counters to track service
time for different types of operations, across several dimensions (e.g.
did we hit the plan cache, was a remote involved, etc.)
jberryman added a commit to jberryman/graphql-engine that referenced this issue Jan 30, 2020
…3552

We upload a set of accumulating timers and counters to track service
time for different types of operations, across several dimensions (e.g.
did we hit the plan cache, was a remote involved, etc.)

Also...

Standardize on DiffTime as a standard duration type, and try to use it
consistently.

See discussion here:
hasura#3584 (review)

It should be possible to overwrite that module so the new threadDelay
sticks per the pattern in hasura#3705 blocked on hasura#3558

Rename the Control.Concurrent.Extended.threadDelay to `sleep` since a
naive use with a literal argument would be very bad!

We catch a bug in 'computeTimeDiff'.

Add convenient 'Read' instances to the time unit utility types. Make
'Second' a newtype to support this.
lexi-lambda added a commit that referenced this issue Feb 4, 2020
…or-cache

Add request timings and count histograms to telemetry. Closes #3552
polRk pushed a commit to polRk/graphql-engine that referenced this issue Feb 12, 2020
…3552

We upload a set of accumulating timers and counters to track service
time for different types of operations, across several dimensions (e.g.
did we hit the plan cache, was a remote involved, etc.)

Also...

Standardize on DiffTime as a standard duration type, and try to use it
consistently.

See discussion here:
hasura#3584 (review)

It should be possible to overwrite that module so the new threadDelay
sticks per the pattern in hasura#3705 blocked on hasura#3558

Rename the Control.Concurrent.Extended.threadDelay to `sleep` since a
naive use with a literal argument would be very bad!

We catch a bug in 'computeTimeDiff'.

Add convenient 'Read' instances to the time unit utility types. Make
'Second' a newtype to support this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/server Related to server p/medium non-urgent issues/features that are candidates for being included in one of the upcoming sprints s/wip Status: This issue is a work in progress
Projects
None yet
Development

No branches or pull requests

3 participants