Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

version check bugs on cli #3706

Closed
fred8617 opened this issue Jan 15, 2020 · 4 comments
Closed

version check bugs on cli #3706

fred8617 opened this issue Jan 15, 2020 · 4 comments
Assignees
@shahidhk
Labels
c/cli Related to CLI k/enhancement New feature or improve an existing feature p/urgent Immediate action required

Comments

@fred8617
Copy link

image
image
@shahidhk shahidhk changed the title cli version show warnings on version incompatability Jan 15, 2020
@shahidhk shahidhk changed the title show warnings on version incompatability show warnings on version incompatibility Jan 15, 2020
@shahidhk shahidhk added the c/cli Related to CLI label Jan 15, 2020
@shahidhk shahidhk changed the title show warnings on version incompatibility don't quit on version incompatibility Jan 15, 2020
@shahidhk shahidhk added k/enhancement New feature or improve an existing feature p/urgent Immediate action required labels Jan 15, 2020
@shahidhk shahidhk self-assigned this Jan 15, 2020
@shahidhk
Copy link
Member

@fred8617 This is a bug in the CLI on how versions are compared. We missed a pre-release nuance while building the constraint for comparision.

Please install the CLI again to get the latest version: https://docs.hasura.io/1.0/graphql/manual/hasura-cli/install-hasura-cli.html

@shahidhk shahidhk changed the title don't quit on version incompatibility version check bugs on cli Jan 15, 2020
shahidhk added a commit to shahidhk/graphql-engine that referenced this issue Jan 15, 2020
@shahidhk
fix various version-related issues with cli (close hasura#3706)
e6cf501 
- do not quit on server-cli version mismatch, show warning
- fix a bug in update-cli command which prevets updates to pre-release
versions
- if a console template for a particular version is not found, use the
latest template
@shahidhk shahidhk mentioned this issue Jan 15, 2020
Merged
1 task
@lukaspili
Copy link

lukaspili commented Jan 15, 2020 •
edited
Loading

Installing the CLI from scratch does not solve the issue.
It's caused by https://releases.hasura.io/graphql-engine?agent=cli-get.sh still returning 1.0.0.
I was able to fix it by tweaking theget.sh and manually specify the cli download url to be from the 1.1.0-beta.1 release.

@heliocaruccio
Copy link

https://www.npmjs.com/package/hasura-cli is out of date

@shahidhk
Copy link
Member

shahidhk commented Jan 16, 2020 •
edited
Loading

We've identified an issue with v1.1.0-beta.1 release and it is recommended that you downgrade to v1.0.0 - instructions here: #3710 (comment)

polRk pushed a commit to polRk/graphql-engine that referenced this issue Feb 12, 2020
@shahidhk @polRk
fix various version-related issues with cli (close hasura#3706) (hasu…
78b4fa8 
…ra#3709)

- do not quit on server-cli version mismatch, show warning
- fix a bug in update-cli command which prevets updates to pre-release
versions
- if a console template for a particular version is not found, use the
latest template
This was referenced Sep 19, 2023
Open
Open
Open
@sumodgeorge sumodgeorge mentioned this issue Sep 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shahidhk shahidhk

Labels
c/cli Related to CLI k/enhancement New feature or improve an existing feature p/urgent Immediate action required
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lukaspili @heliocaruccio @shahidhk @fred8617