Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allowList property omitted during application of metadata snapshot #4687

Closed
rhyslbw opened this issue May 6, 2020 · 0 comments · Fixed by #4762
Closed

allowList property omitted during application of metadata snapshot #4687

rhyslbw opened this issue May 6, 2020 · 0 comments · Fixed by #4762
Assignees
Labels
c/server Related to server k/bug Something isn't working

Comments

@rhyslbw
Copy link

rhyslbw commented May 6, 2020

I've prepared a minimum reproduction
Docker image hasura/graphql-engine:v1.2.1.cli-migrations

The allowList property from the provided snapshot is not applied on startup, as demonstrated by a subsequent export of the metadata with no changes:

Starting with

{
  ...
  "query_collections": [
    {
      "name": "allowed-queries",
      "definition": {
        "queries": [
          {
            "name": "allowed",
            "query": "query allowed {\n  foo {\n    id\n  }\n}"
          }
        ]
      }
    }
  ],
  "allowlist": [
    {
      "collection": "allowed-queries"
    }
  ]
}

After container starts

{
  ...
  "query_collections": [
    {
      "name": "allowed-queries",
      "definition": {
        "queries": [
          {
            "name": "allowed",
            "query": "query allowed {\n  foo {\n    id\n  }\n}"
          }
        ]
      }
    }
  ]
}

Remove, then manually re-add via console

{
  ...
  "query_collections": [
    {
      "name": "allowed-queries",
      "definition": {
        "queries": [
          {
            "name": "allowed",
            "query": "query allowed {\n  foo {\n    id\n  }\n}"
          }
        ]
      }
    }
  ],
  "allowlist": [
    {
      "collection": "allowed-queries"
    }
  ]
}

☝️ Matches the snapshot provided to the container

@tirumaraiselvan tirumaraiselvan added support/needs-triage Needs to be triaged so that we have enough information to add this to our backlog c/server Related to server labels May 11, 2020
@codingkarthik codingkarthik self-assigned this May 13, 2020
@tirumaraiselvan tirumaraiselvan added k/bug Something isn't working and removed support/needs-triage Needs to be triaged so that we have enough information to add this to our backlog labels May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/server Related to server k/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants