changes for v1.2.2 (update) #4927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a#3239) (hasura#4551) * Add support for multiple top-level fields in a subscription to improve testability of subscriptions * Add an internal flag to enable multiple subscriptions * Add missing call to withConstructorFn in live queries (fix hasura#3239) Co-authored-by: Alexis King <lexi.lambda@gmail.com>
There are two implementations of a Cache, namely a bounded and an unbounded variant. This can be elegantly captured in a type class. In addition to reducing the amount of error-prone code in the definition of the cache, this version reduces the amount of error-prone code in usage sites of the cache, as it makes the cache into an abstract object, so that a calling site cannot distinguish between cache types. Any decision about what should be cached should be made through the interface of a cache, rather than at the callsite, and this is captured by this variant.
This also seems to squash a stubborn space leak we see with subscriptions (linking to canonical hasura#3388 for reference). This may also fix some of the "Unexpected exception" websockets exceptions we are now surfacing (see e.g. hasura#4344) Also: dev.sh: fix hpc reporting Initial work on this done by Vamshi.
…asura#4344 ...hopefully. At least I no longer can easily induce any unexpected exceptions after this and the GHC 8.10 + libs upgrade commit.
fix bug which was not allowing the allowlist to be imported
…#4801) * flush log buffer on exception in mkWaiApp * add comment to explain the introduced change * add changelog
…asura#4661) Introspection queries accept variables, but we need to make sure to also touch the variables that we ignore, so that an introspection query is marked not reusable if we are not able to build a correct query plan for it. A better solution here would be to deal with such unused variables correctly, so that more introspection queries become reusable. An even better solution would be to type-safely track *how* to reuse which variables, rather than to split the reusage marking from the planning. Co-authored-by: Tirumarai Selvan <tiru@hasura.io>
rikinsk
approved these changes
May 29, 2020
|
Review app https://hge-ci-pull-4927.herokuapp.com is deleted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
server: fix explain queries with role permissions (fix Analyze button does not show permission filters anymore #4816)
server: compile with GHC 8.10.1, closing a space leak with subscriptions. (close Migrate to GHC 8.10 #4517) (Memory usage accumulating over time until crash / restart #3388)
server: fixes an issue where introspection queries with variables would fail because of caching (fix Introspection-query error #4547)
server: avoid loss of precision when passing values in scientific notation (fix [BUG] Hasura doesn't calculate correctly small numbers _inc #4733)
server: fix mishandling of GeoJSON inputs in subscriptions (fix "postgres query error" when using subscriptions and "_st_d_within" expression to compare columns of type geography #3239)
server: fix importing of allow list query from metadata (fix allowList property omitted during application of metadata snapshot #4687)
server: fix edge case with printing logs on startup failure (fix Not writing errors to docker log #4772)
Changelog
CHANGELOG.mdis updated with user-facing content relevant to this PR.Affected components
Related Issues
Solution and Design
Steps to test and verify
Limitations, known bugs & workarounds
Server checklist
Catalog upgrade
Does this PR change Hasura Catalog version?
Metadata
Does this PR add a new Metadata feature?
run_sqlauto manages the new metadata through schema diffing?run_sqlauto manages the definitions of metadata on renaming?export_metadata/replace_metadatasupports the new metadata added?GraphQL
Breaking changes
No Breaking changes
There are breaking changes:
Metadata API
Existing
querytypes:argspayload which is not backward compatibleJSONschemaGraphQL API
Schema Generation:
NamedTypeSchema Resolve:-
nullvalue for any input fieldsLogging
JSONschema has changedtypenames have changed