Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document the explain api #870

Closed
0x777 opened this issue Oct 26, 2018 · 0 comments
Closed

document the explain api #870

0x777 opened this issue Oct 26, 2018 · 0 comments
Assignees
@0x777
Labels
c/docs Related to docs e/intermediate can be wrapped up in a week p/high candidate for being included in the upcoming sprint

Comments

@0x777
Copy link
Member

0x777 commented Oct 26, 2018

No description provided.

@0x777 0x777 added c/docs Related to docs e/intermediate can be wrapped up in a week labels Oct 26, 2018
@0x777 0x777 self-assigned this Oct 26, 2018
@dsandip dsandip added the p/high candidate for being included in the upcoming sprint label Jan 8, 2020
@marionschleifer marionschleifer mentioned this issue Jan 31, 2020
Closed
@0x777 0x777 closed this as completed in 2b977bb Feb 3, 2020
polRk pushed a commit to polRk/graphql-engine that referenced this issue Feb 12, 2020
@marionschleifer @polRk
docs: document explain api (close hasura#870) (hasura#3739)
2a3f286
hasura-bot pushed a commit that referenced this issue Jul 23, 2024
@0x777 @hasura-bot
Do not replace the existing analyzer rules (#870)
a6dbc7b 
<!-- The PR description should answer 2 (maybe 3) important questions:
-->

### What

This PR fixes issues in the SQL layer where the following queries would
fail:

1. `select count(*) from "Track"`
2. `select * from "Track" where id = 1`

<!-- Consider: do we need to add a changelog entry? -->

### How

These were failing because the built-in analyzer rules that rewrite
`count(*)` and type-cast expressions weren't firing.
`with_analyzer_rules` replaces the analyzer rules of a session context
with the given list. We want our analyzer rule to be fired in addition
to the built-in analyzer rules.

Tests are being worked on in a separate PR.

V3_GIT_ORIGIN_REV_ID: 42231f97b5b28d9b7eeff0c3e592cb43ff7d952f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0x777 0x777

Labels
c/docs Related to docs e/intermediate can be wrapped up in a week p/high candidate for being included in the upcoming sprint
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@0x777 @dsandip