Adding a hasura-default naming convention for MSSQL / SQL Server

[kevinmichaelchen]

Version Information

Server Version: v2.17.1
CLI Version (for CLI related issue): v2.17.1

Environment

EE — since we're using a HASURA_GRAPHQL_PRO_KEY env var

What is the current behaviour?

We've set a global naming convention to be graphql-default with this env var:

HASURA_GRAPHQL_DEFAULT_NAMING_CONVENTION: graphql-default

However, when we're connecting to a SQLServer / MSSQL database, due to their case sensitivity, we have to use hasura-default in order to override the globally-defined behavior.

The UI currently makes this difficult.

What is the expected behaviour?

Either the UI should default to and only allow hasura-default for MSSQL, or it should be automatically set in metadata.

How to reproduce the issue?

1. Introduce a new DB connection to a MSSQL instance
2. Try to set the DB's naming convention.

Screenshots or Screencast

Please provide any traces or logs that could help here.

Any possible solutions/workarounds you're aware of?

Keywords

[deinspanjer]

How to reproduce the issue?

1. Set HASURA_GRAPHQL_DEFAULT_NAMING_CONVENTION: graphql-default
2. Introduce a new DB connection to a MSSQL instance
3. Attempt to save the connection and get an error that MSSQL doesn't support graphql-default
4. Get frustrated because there is no way to "fix" this other than unsetting the env var which would mess up prior work.

Any possible solutions/workarounds you're aware of?

It is possible to work around this, but it is a very ugly hack and surfaces a separate bug that should actually be looked into.
Follow steps 1 and 2 from above
3. Purposefully misconfigure the database connection form to indicate it is a Postgres database even though it is actually MSSQL (don't click submit yet!)
4. Scroll down and expand the now visible configuration section for setting the naming convention.
5. Change the naming convention to hasura-default
6. Scroll back up to the top and change the database type back to MSSQL which will cause that configuration section to disappear again (but the setting you applied is still part of the form that will be submitted. yuck but good for us)
7. Now submit the connection which should be accepted.

[manasag]

Hi folks, we are acknowledging this issue and this is currently being fixed.

[paritosh-08]

Closed via 96549b2