Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hasura 2.x docs state snake-cased pk_columns in mutations, yet Hasura 2.21 uses camelCase #9553

Open
CuriousLearner opened this issue Apr 11, 2023 · 2 comments
Labels
k/bug Something isn't working t/gql-services

Comments

@CuriousLearner
Copy link

Version Information

Server Version: 2.21

Environment

OSS

What is the current behaviour?

Upgrading Hasura from 2.16.0 to 2.21.0 broke the mutations, since the pk_columns in default mutations are referenced as camelCase pkColumns.

There is no mention in the release notes about this change.

Furthermore, a minor version upgrade should not have a breaking change.

What is the expected behaviour?

A minor version upgrade should not have breaking change in the API.

How to reproduce the issue?

  1. Use mutation with pk_columns in version 2.16.0
  2. Upgrade to 2.21.0
  3. Now mutations uses pkColumns.

Any possible solutions/workarounds you're aware of?

Degrading back to 2.16.0

Keywords

breaking-change, camecase, snakecase, pk columns

@CuriousLearner CuriousLearner added the k/bug Something isn't working label Apr 11, 2023
@rikinsk
Copy link
Member

rikinsk commented Apr 18, 2023

Hey there were some fixes related to the naming conventions feature introduced in v2.21.

"Fix graphql-default naming convention bugs (#9426, #9430)"

Can you confirm if you were using the graphql-default naming convention? That might explain this behaviour

@CuriousLearner
Copy link
Author

@rikinsk Yes, we have graphql-default naming-convention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
k/bug Something isn't working t/gql-services
Projects
None yet
Development

No branches or pull requests

3 participants