Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Auth0 docs to note which token to update when using auth0-spa-js. #3367

Merged
merged 2 commits into from
Dec 17, 2019

Conversation

nirvdrum
Copy link
Contributor

Description

Depending on which Auth0 SDK you're using, the rules you use to add Hasura claims to the JWT need to be adjusted. This change clarifies the differences and provides code samples for them.

Affected components

  • Docs
  • Community Content

Catalog upgrade

Does this PR change Hasura Catalog version?

  • No
  • Yes
    • Updated docs with SQL for downgrading the catalog

Metadata

Does this PR add a new Metadata feature?

  • No
  • Yes
    • Does run_sql auto manages the new metadata through schema diffing?
      • Yes
      • Not required
    • Does run_sql auto manages the definitions of metadata on renaming?
      • Yes
      • Not required
    • Does export_metadata/replace_metadata supports the new metadata added?
      • Yes
      • Not required

GraphQL

  • No new GraphQL schema is generated
  • New GraphQL schema is being generated:
    • New types and typenames are correlated

Breaking changes

  • No Breaking changes

  • There are breaking changes:

    1. Metadata API

      Existing query types:

      • Modify args payload which is not backward compatible
      • Behavioural change of the API
      • Change in response JSON schema
      • Change in error code
    2. GraphQL API

      Schema Generation:

      • Change in any NamedType
      • Change in table field names

      Schema Resolve:-

      • Change in treatment of null value for any input fields
    3. Logging

      • Log JSON schema has changed
      • Log type names have changed

@hasura-bot
Copy link
Contributor

Beep boop! 🤖

Hey @nirvdrum, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible.

Stay awesome! 😎

@CLAassistant
Copy link

CLAassistant commented Nov 17, 2019

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link

netlify bot commented Nov 17, 2019

Deploy preview for hasura-docs ready!

Built with commit 4afcbe7

https://deploy-preview-3367--hasura-docs.netlify.com

@marionschleifer marionschleifer added c/docs Related to docs c/community Related to community content labels Nov 21, 2019
Copy link
Member

@praveenweb praveenweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The sample apps actually use the older version of Auth0 right now. The code upgrade can happen in a different PR if necessary.

@tirumaraiselvan
Copy link
Contributor

@rikinsk Pinging you to merge this.

@rikinsk rikinsk merged commit 5634dbf into hasura:master Dec 17, 2019
@hasura-bot
Copy link
Contributor

Beep boop! 🤖

GIF

Awesome work @nirvdrum! All of us at Hasura ❤️ what you did.

Thanks again 🤗

@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-3367.herokuapp.com is deleted

polRk pushed a commit to polRk/graphql-engine that referenced this pull request Feb 12, 2020
@nirvdrum nirvdrum deleted the update-auth0-docs branch February 21, 2020 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/community Related to community content c/docs Related to docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants