pretty print the json object while exporting to file, fix #3690

[codingkarthik]

Description

Affected components

• Server
• Console
• CLI
• Docs
• Community Content
• Build System
• Tests
• Other (list it)

Related Issues

#3690

Solution and Design

Added the space parameter in the JSON.stringify() function.

Steps to test and verify

Export the metadata.json file

Limitations, known bugs & workarounds

Server checklist

Catalog upgrade

Does this PR change Hasura Catalog version?

• [ X] No
• Yes
  • Updated docs with SQL for downgrading the catalog

Metadata

Does this PR add a new Metadata feature?

• [ X] No
• Yes
  • Does run_sql auto manages the new metadata through schema diffing?
    • Yes
    • Not required
  • Does run_sql auto manages the definitions of metadata on renaming?
    • Yes
    • Not required
  • Does export_metadata/replace_metadata supports the new metadata added?
    • Yes
    • Not required

GraphQL

• [ X] No new GraphQL schema is generated
• New GraphQL schema is being generated:
  • New types and typenames are correlated

Breaking changes

• [X ] No Breaking changes

• There are breaking changes:

  1. Metadata API

     Existing query types:

     • Modify args payload which is not backward compatible
     • Behavioural change of the API
     • Change in response JSON schema
     • Change in error code

  2. GraphQL API

     Schema Generation:

     • Change in any NamedType
     • Change in table field names

     Schema Resolve:-

     • Change in treatment of null value for any input fields

  3. Logging

     • Log JSON schema has changed
     • Log type names have changed

[hasura-bot]

Beep boop! 🤖

Hey @codingkarthik, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible.

Stay awesome! 😎

[claassistantio]

All committers have signed the CLA.

[netlify]

Deploy preview for hasura-docs ready!

Built with commit 84e1010

https://deploy-preview-3694--hasura-docs.netlify.com

[hasura-bot]

Review app for commit b37bc12 deployed to Heroku: https://hge-ci-pull-3694.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3694-b37bc129

[rikinsk]

@codingkarthik Thanks for raising this PR so quickly! Could you please sign the CLA so we can merge this.

[rikinsk]

Could you set indent size to 2 in place of 4. 4 seems a little extra spaced out

[codingkarthik]

Sure @rikinsk, I'll make that change

[codingkarthik]

Hey Richin, I have made the changes and also signed the CLA.

…

On Mon, Jan 13, 2020, 6:51 PM Rikin Kachhia ***@***.***> wrote: ***@***.**** requested changes on this pull request. ------------------------------ In console/src/components/Common/utils/jsUtils.js <#3694 (comment)> : > @@ -225,7 +225,10 @@ export const downloadObjectAsJsonFile = (fileName, object) => { : fileName + jsonSuffix; const dataString = - 'data:' + contentType + ',' + encodeURIComponent(JSON.stringify(object)); + 'data:' + + contentType + + ',' + + encodeURIComponent(JSON.stringify(object, null, 4)); Could you set indent size to 2 in place of 4. 4 seems a little extra spaced out — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3694?email_source=notifications&email_token=ADXBJWH4MU7E2HKPXBLPQ7LQ5RTGLA5CNFSM4KGBTN32YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCRQANPQ#pullrequestreview-341837502>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADXBJWDVRXMOYZ2SKPJHEYTQ5RTGLANCNFSM4KGBTN3Q> .

[hasura-bot]

Review app for commit 554ba13 deployed to Heroku: https://hge-ci-pull-3694.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3694-554ba132

[hasura-bot]

Beep boop! 🤖

Awesome work @codingkarthik! All of us at Hasura ❤️ what you did.

Thanks again 🤗

[hasura-bot]

Review app https://hge-ci-pull-3694.herokuapp.com is deleted

[hasura-bot]

Review app for commit 84e1010 deployed to Heroku: https://hge-ci-pull-3694.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3694-84e10105