Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

St with timezone #3950

Closed
wants to merge 63 commits into from
Closed

St with timezone #3950

wants to merge 63 commits into from

Conversation

codingkarthik
Copy link
Contributor

Description

Affected components

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System
  • Tests
  • Other (list it)

Related Issues

Solution and Design

Steps to test and verify

Limitations, known bugs & workarounds

Server checklist

Catalog upgrade

Does this PR change Hasura Catalog version?

  • No
  • Yes
    • Updated docs with SQL for downgrading the catalog

Metadata

Does this PR add a new Metadata feature?

  • No
  • Yes
    • Does run_sql auto manages the new metadata through schema diffing?
      • Yes
      • Not required
    • Does run_sql auto manages the definitions of metadata on renaming?
      • Yes
      • Not required
    • Does export_metadata/replace_metadata supports the new metadata added?
      • Yes
      • Not required

GraphQL

  • No new GraphQL schema is generated
  • New GraphQL schema is being generated:
    • New types and typenames are correlated

Breaking changes

  • No Breaking changes

  • There are breaking changes:

    1. Metadata API

      Existing query types:

      • Modify args payload which is not backward compatible
      • Behavioural change of the API
      • Change in response JSON schema
      • Change in error code

    2. GraphQL API

      Schema Generation:

      • Change in any NamedType
      • Change in table field names

      Schema Resolve:-

      • Change in treatment of null value for any input fields

    3. Logging

      • Log JSON schema has changed
      • Log type names have changed

tirumaraiselvan and others added 30 commits December 12, 2019 16:33
@tirumaraiselvan
init
55e8f39
@tirumaraiselvan
rename files
332f1ca
@tirumaraiselvan
WIP
4f2d7f6
@tirumaraiselvan
[temp] allow warnings
85ac116
@tirumaraiselvan
support one-off type
522513b
@tirumaraiselvan
[wip] take optional payload
c938522
@tirumaraiselvan
log invocations for each request
879c88a
@tirumaraiselvan
change application currentTime to db now()
a004ddc
@tirumaraiselvan
on delete cascade
0b2f12e
@tirumaraiselvan
change time formatting
7386d8d
@tirumaraiselvan
bugfix: lock on id and not name
dc0fd1e
@tirumaraiselvan
run scheduler every 10 s
7f4acc1
@tirumaraiselvan
add retry conf
b8e8c07
@tirumaraiselvan
derive Lift using custom cron package, also add retry_conf to metadata
36ba5c5
@lexi-lambda
Re-enable -Werror in CI
46f2962
@tirumaraiselvan
bump lts, upgrade time, refactors, stub functions
a79083b
@tirumaraiselvan
process dead event
322ee8b
@tirumaraiselvan
add scheduled trigger to cache
981578b
@tirumaraiselvan
take webhook from env and use schema-cache more effectively
96acd3a
@tirumaraiselvan
describe time formats in the API
4178215
@tirumaraiselvan
fix WIP compilation errors
32626c5
@tirumaraiselvan
Merge branch 'master' of github.com:hasura/graphql-engine into schedu…
4f1939d 
…led-triggers

# Conflicts:
#	server/graphql-engine.cabal
#	server/src-lib/Hasura/App.hs
#	server/stack.yaml
#	server/stack.yaml.lock
@tirumaraiselvan
add retry functionality
c011638
@tirumaraiselvan
[wip] implement cancel_scheduled_event api
5fb35ad
@tirumaraiselvan
implement cancel_scheduled_event api
3d3605d
@tirumaraiselvan
implement delete_scheduled_trigger api
dec2857
@tirumaraiselvan
implement update_scheduled_trigger
bc22952
@tirumaraiselvan
Merge remote-tracking branch 'upstream/master' into scheduled-triggers
9581af8 
# Conflicts:
#	server/graphql-engine.cabal
#	server/src-lib/Hasura/Eventing/EventTrigger.hs
#	server/src-lib/Hasura/RQL/Types.hs
#	server/src-lib/Hasura/RQL/Types/SchemaCache.hs
@tirumaraiselvan
Merge remote-tracking branch 'upstream/master' into scheduled-triggers
822d3f4 
# Conflicts:
#	server/src-lib/Hasura/SQL/Types.hs
#	server/src-rsr/initialise.sql
#	server/stack.yaml
#	server/stack.yaml.lock
@tirumaraiselvan
Merge remote-tracking branch 'upstream/master' into scheduled-triggers
d88d155 
# Conflicts:
#	server/src-lib/Hasura/RQL/DDL/Schema/Cache.hs
tirumaraiselvan and others added 22 commits February 11, 2020 16:00
@tirumaraiselvan
use unfoldr
c1aa809
@tirumaraiselvan
add docs and remove unnecessary pragmas
47d2601
@tirumaraiselvan
move orphaned instances to Hasura.RQL.Instances
245e296
@tirumaraiselvan
create one-off event during creation
c8638e5
@tirumaraiselvan
only include scheduled triggers in metadata if specified in api
2c0dcaf
@tirumaraiselvan
add scheduled triggers to metadata apis
2d87c7b
@tirumaraiselvan
implement track_scheduled_trigger api and remove `include_in_metada…
1db07fe 
…ta` from create api
@tirumaraiselvan
update docs
6cea9c4
@tirumaraiselvan
few bug fixes
b3aa0b6
@tirumaraiselvan
add untrack_scheduled_trigger api
74c7d74
@tirumaraiselvan
change OneOff to AdHoc type and implement create_scheduled_event api
90d0d1c
@tirumaraiselvan
adhoc trigger takes an optional timestamp value
98a490b
@tirumaraiselvan
change logic of creating upcoming events (from next day to next 100)
748ea4e
@tirumaraiselvan
create scheduled events for cron during create also
6fb69e0
@tirumaraiselvan
mark column as cancelled instead of deleting row for `cancel_schedu…
d8ad5db 
…led_event` api
@tirumaraiselvan
validate (non)existence of scheduled trigger in DDLs
3f8c6ea
@tirumaraiselvan
merge master
0919f9a
@tirumaraiselvan
add downgrade 33_to_32
818344a
@codingkarthik
add a new column 'header_conf' in the scheduled_trigger table (hasura#78
bf5d4e8 
)

While an event of the ST is fired, the headers will also be sent
@tirumaraiselvan
no-op
b4fab74
@codingkarthik
add tests for scheduled triggers (hasura#79)
0ca80a7 
  - Make a new scheduled events webhook server on port 5594
  - Setting the session timezone of the db to UTC so that
    "SELECT NOW()" returns UTC time.
  - Cron's schedule is set from 30 mins from the time the tests run, so it
    will not be run(to avoid race condition between the cron ST and the adhoc
    ST)
  - The tests will run for a maximum of a minute(until the event is fired)
@codingkarthik
change the data type of scheduled_time to TIMESTAMPTZ
55c6847
@hasura-bot
Copy link
Contributor

Beep boop! 🤖

Hey @codingkarthik, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible.

Stay awesome! 😎

@netlify
Copy link

netlify bot commented Feb 25, 2020

Deploy preview for hasura-docs ready!

Built with commit 55c6847

https://deploy-preview-3950--hasura-docs.netlify.com

@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-3950.herokuapp.com is deleted

This was referenced Sep 19, 2023
Open
Open
Open
@sumodgeorge sumodgeorge mentioned this pull request Sep 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@codingkarthik @hasura-bot @tirumaraiselvan @lexi-lambda