cli: remove migration files if api returns error (close #4312) #4319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocation from console
|
Review app for commit b419306 deployed to Heroku: https://hge-ci-pull-4319.herokuapp.com |
|
Review app for commit 3ef083b deployed to Heroku: https://hge-ci-pull-4319.herokuapp.com |
scriptonist
approved these changes
Apr 8, 2020
shahidhk
approved these changes
Apr 8, 2020
shahidhk
changed the title
shahidhk
changed the title
|
Review app https://hge-ci-pull-4319.herokuapp.com is deleted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the bug with CLI migrate API which doesn't delete the migration files if the request fails.
Changelog
CHANGELOG.mdis updated with user-facing content relevant to this PR.Affected components
Related Issues
#4312
Solution and Design
Steps to test and verify
Limitations, known bugs & workarounds