Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ndc-models directly to avoid openssl everywhere #156

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Use ndc-models directly to avoid openssl everywhere #156

merged 1 commit into from
Dec 11, 2024

Conversation

danieljharvey
Copy link
Collaborator

What

Fix a problem in #155 where pulling query-engine-translation into the configuration crate was pulling openssl in. Turns out we're still pulling ndc-models from the ndc-sdk here (probably from before ndc-models became it's own crate).

How

Use ndc-models directly instead of ndc-sdk.

@danieljharvey danieljharvey added this pull request to the merge queue Dec 11, 2024
Merged via the queue into main with commit f529344 Dec 11, 2024
18 checks passed
@danieljharvey danieljharvey deleted the djh/use-ndc-models-directly branch December 11, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codedmart codedmart codedmart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danieljharvey @codedmart