support skipping count aggregate on hasura #120
Merged
+60
−37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #117
current hasura graphql provider always make an aggregate count call
which is very expensive on most RDMS like postgres.
this PR introduces a very simple workaround. when caller providers
aggregateFieldName(resource) = NO_COUNT
we simply skip count call and provide partial pagination instead.This is a NO-OP unless caller provide custom aggregateFiledName function.
TEST
called sample app with and without
and verified the behavior.