-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge "titotix/refactoring" into "jbremer/master" #1
base: main
Are you sure you want to change the base?
Conversation
export code from bin/peepdf to PDFOutput.py
code from peepdf main script is dispatched around PDFCore, PDFOutput & PDFUtils The main script peepdf is now a wrapper to this moved code
intro will show the report of the provided file This was normal behaviour before refactoring
constants file contains all constant variable like project info, author...
getReport is a wrapper to getPeepReport, getPeepJSON & getPeepXML
Cool. Could you elaborate on the exact changes in this PR? I see a lot of code moving around etc. |
Well, after manually merging your PR (due to me updating the version identifier) I can tell you that the only unit test that |
Yap, |
As discuss in jesparza#57, main changes compared to your work are :
|
I revert my change and put back an error code "0" to Edit: Whoa, that wasn't supposed to increase the coverage ^^' |
Thanks. I'll first have to create one or two more unit tests to ensure that the usage, as we have it in @cuckoosandbox, remains working properly. |
Hey,
I merged our work and will continue further ahead as we discuss jesparza#57.