Convert latency thresholds from magic numbers to named constants #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functional change, just minor code cleanup. Not sure whether it would be better to name these
YELLOW/REDorGREEN/YELLOW, orGREEN_YELLOW/YELLOW_RED.The thing is I was setting up similar thresholds in my grafana, and got curious which these are in oha which I often use, but I've had to spend a few minutes to find them, which wouldn't have been the case if these were named constants.
Out of curiosity, what are your thresholds based on? For now I've only been able to find justification for 400ms threshold, and I'd probably set this as red, while yellow would be some lower value known to be unnoticeable to user, maybe around 50ms.