Feature: Reading Urls from file

[chr1st1ank]

Firstly, thanks for this great little tool. It works like a charm and is just what I needed.

I was missing one feature and I'm suggesting it here, please let me know if it is wanted. For now, I've implemented and used it only for myself.

The feature needed was, that the load can be distributed over multiple valid URLs. With the regex feature I would have seen almost only HTTP 404 on the service that I wanted to test. So the idea was to get URLs from a real access log and put them into a file.

This implementation here makes oha:

• take the filename instead of a single URL
• read all the lines and validate if they are valid URLs
• Use random URLs from the list during the load test

The feature is behind the new command line flag --urls-from-file.

What do you think about this?

[hatoo]

Thank you!
It looks good!

I added a small change request.

I'll merge it after your fix.

[chr1st1ank]

Thank you! It looks good!

I added a small change request.

I'll merge it after your fix.

Ok, great. I went over the code again to improve the error handling and add some tests. Now it's ready.

[hatoo]

Thank you!