Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated install.sh to remove github api #293

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

zackbradys
Copy link
Member

Please check below, if the PR fulfills these requirements:

  • Commit(s) and code follow the repositories guidelines.
  • Test(s) have been added or updated to support these change(s).
  • Doc(s) have been added or updated to support these change(s).

Associated Links:

Types of Changes:

  • Bugfix

Proposed Changes:

  • Updated the install.sh script to use the GitHub Releases page instead of the GitHub API due to unauthenticated rate limiting from the GitHub API.
  • Added additional logging to inform users to set HAULER_VERSION

Verification/Testing of Changes:

  • curl -sfL https://raw.githubusercontent.com/zackbradys/hauler/main/install.sh | bash

Additional Context:

  • N/A

@zackbradys zackbradys self-assigned this Aug 14, 2024
@zackbradys zackbradys added bug Something isn't working size/S Denotes an issue/PR requiring a relatively small amount of work labels Aug 14, 2024
@zackbradys zackbradys added this to the Hauler v1.1.0 milestone Aug 14, 2024
@zackbradys zackbradys linked an issue Aug 14, 2024 that may be closed by this pull request
dweomer
dweomer previously approved these changes Aug 14, 2024
install.sh Outdated Show resolved Hide resolved
Signed-off-by: Jacob Blain Christen <dweomer5@gmail.com>
@dweomer
Copy link
Contributor

dweomer commented Aug 14, 2024

@zackbradys I suggested (and committed) a change to fix an encountered issue:

$ curl -fsL https://raw.githubusercontent.com/hauler-dev/hauler/52194fa74c1135a51a75ff8ab9cc7d5efa8d0361/install.sh | bash -x
+ '[' '' = true ']'
+ info 'Starting Preflight Checks...'
+ echo

+ echo '[INFO] Hauler: Starting Preflight Checks...'
[INFO] Hauler: Starting Preflight Checks...
+ for cmd in echo curl grep sed rm mkdir awk openssl tar install source
+ command -v echo
+ for cmd in echo curl grep sed rm mkdir awk openssl tar install source
+ command -v curl
+ for cmd in echo curl grep sed rm mkdir awk openssl tar install source
+ command -v grep
+ for cmd in echo curl grep sed rm mkdir awk openssl tar install source
+ command -v sed
+ for cmd in echo curl grep sed rm mkdir awk openssl tar install source
+ command -v rm
+ for cmd in echo curl grep sed rm mkdir awk openssl tar install source
+ command -v mkdir
+ for cmd in echo curl grep sed rm mkdir awk openssl tar install source
+ command -v awk
+ for cmd in echo curl grep sed rm mkdir awk openssl tar install source
+ command -v openssl
+ for cmd in echo curl grep sed rm mkdir awk openssl tar install source
+ command -v tar
+ for cmd in echo curl grep sed rm mkdir awk openssl tar install source
+ command -v install
+ for cmd in echo curl grep sed rm mkdir awk openssl tar install source
+ command -v source
+ HAULER_INSTALL_DIR=/usr/local/bin
+ '[' '!' -d /usr/local/bin ']'
+ '[' '!' -w /usr/local/bin ']'
+ '[' '' = true ']'
+ '[' -z '' ']'
++ curl -sI https://github.com/hauler-dev/hauler/releases/latest
++ grep -i location
++ sed 's#.*tag/v##'
+ HAULER_VERSION=$'1.0.7\r'
+ '[' -z $'1.0.7\r' ']'
++ uname -s
++ tr '[:upper:]' '[:lower:]'
+ PLATFORM=linux
+ case $PLATFORM in
+ PLATFORM=linux
++ uname -m
+ ARCH=x86_64
+ case $ARCH in
+ ARCH=amd64
+ info 'Starting Installation...'
+ echo

+ echo '[INFO] Hauler: Starting Installation...'
[INFO] Hauler: Starting Installation...
' verbose '- Version: v1.0.7
' echo '- Version: v1.0.7
- Version: v1.0.7
+ verbose '- Platform: linux'
+ echo '- Platform: linux'
- Platform: linux
+ verbose '- Architecture: amd64'
+ echo '- Architecture: amd64'
- Architecture: amd64
+ verbose '- Install Directory: /usr/local/bin'
+ echo '- Install Directory: /usr/local/bin'
- Install Directory: /usr/local/bin
+ '[' '!' -d /root/.hauler ']'
+ chmod -R 777 /root/.hauler
+ cd /root/.hauler
+ info 'Starting Download...'
+ echo

+ echo '[INFO] Hauler: Starting Download...'
[INFO] Hauler: Starting Download...
+ curl -sfOL $'https://github.com/hauler-dev/hauler/releases/download/v1.0.7\r/hauler_1.0.7\r_checksums.txt'
_checksums.txt' to Download: hauler_1.0.7
+ echo

_checksums.txt' Hauler: Failed to Download: hauler_1.0.7
_checksums.txt: Failed to Download: hauler_1.0.7
+ exit 1

@dweomer dweomer merged commit d633eef into hauler-dev:main Aug 14, 2024
1 check passed
@zackbradys zackbradys deleted the install-script-api-fixes branch August 16, 2024 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/S Denotes an issue/PR requiring a relatively small amount of work
Projects
Status: Resolved
Development

Successfully merging this pull request may close these issues.

[BUG] curl-to-bash install fails when rate-limited
2 participants