Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

continue on error when adding images to store #317

Merged
merged 2 commits into from
Sep 4, 2024
Merged

continue on error when adding images to store #317

merged 2 commits into from
Sep 4, 2024

Conversation

amartin120
Copy link
Contributor

@amartin120 amartin120 commented Sep 4, 2024 •
edited
Loading

Please check below, if the PR fulfills these requirements:

  • Commit(s) and code follow the repositories guidelines.
  • Test(s) have been added or updated to support these change(s).
  • Doc(s) have been added or updated to support these change(s).

Associated Links:

Types of Changes:

  • Feature

Proposed Changes:

  • log errors from cosign save as warnings and continue operations.

Verification/Testing of Changes:

  • Here's an example of hitting a failure and hauler keeps on truckin'.
    image

Additional Context:

@amartin120
continue on error when adding images to store
3b93bd7 
Signed-off-by: Adam Martin <adam.martin@ranchergovernment.com>
dweomer
dweomer reviewed Sep 4, 2024
View reviewed changes
cmd/hauler/cli/store/add.go Outdated Show resolved Hide resolved
@amartin120 @dweomer
Update cmd/hauler/cli/store/add.go
c8e3bd3 
Co-authored-by: Jacob Blain Christen <dweomer5@gmail.com>
Signed-off-by: Adam Martin <42001113+amartin120@users.noreply.github.com>
@amartin120 amartin120 merged commit 5aa55e9 into hauler-dev:main Sep 4, 2024
2 checks passed
dweomer added a commit that referenced this pull request Sep 4, 2024
@amartin120 @dweomer
continue on error when adding images to store (#317)
e42f72f 
* continue on error when adding images to store

Signed-off-by: Adam Martin <adam.martin@ranchergovernment.com>

* Update cmd/hauler/cli/store/add.go

Co-authored-by: Jacob Blain Christen <dweomer5@gmail.com>
Signed-off-by: Adam Martin <42001113+amartin120@users.noreply.github.com>

---------

Signed-off-by: Adam Martin <adam.martin@ranchergovernment.com>
Signed-off-by: Adam Martin <42001113+amartin120@users.noreply.github.com>
Co-authored-by: Jacob Blain Christen <dweomer5@gmail.com>
@dweomer dweomer linked an issue Sep 4, 2024 that may be closed by this pull request
[BUG] Hauler fails to pull Rancher v2.9.x linux/amd64 due to mirrored-prometheus-windows-exporter #315
Closed
@dweomer dweomer mentioned this pull request Sep 4, 2024
Closed
@dweomer dweomer added the bug Something isn't working label Sep 4, 2024
@zackbradys zackbradys mentioned this pull request Sep 5, 2024
Open
@dweomer dweomer mentioned this pull request Sep 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dweomer dweomer dweomer approved these changes

Assignees

@dweomer dweomer

@atoy3731 atoy3731

Labels
bug Something isn't working
Projects
Hauler
Status: Resolved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Hauler fails to pull Rancher v2.9.x linux/amd64 due to mirrored-prometheus-windows-exporter
3 participants
@amartin120 @dweomer @atoy3731