Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added integration tests for non hauler tarballs #325

Merged
merged 7 commits into from
Sep 27, 2024
Merged

added integration tests for non hauler tarballs #325

merged 7 commits into from
Sep 27, 2024

Conversation

zackbradys
Copy link
Member

@zackbradys zackbradys commented Sep 20, 2024 •
edited
Loading

Please check below, if the PR fulfills these requirements:

  • Commit(s) and code follow the repositories guidelines.
  • Test(s) have been added or updated to support these change(s).
  • Doc(s) have been added or updated to support these change(s).

Associated Links:

Types of Changes:

  • Feature

Proposed Changes:

  • Added tests for docker load of hauler outputted tarballs

Verification/Testing of Changes:

  • N/A

Additional Context:

  • N/A

@zackbradys zackbradys self-assigned this Sep 20, 2024
@zackbradys zackbradys requested a review from a team September 20, 2024 21:09
@zackbradys zackbradys added enhancement New feature or request size/S Denotes an issue/PR requiring a relatively small amount of work labels Sep 20, 2024
@zackbradys zackbradys added this to the Hauler v1.1.0 milestone Sep 20, 2024
atoy3731
atoy3731 previously approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@atoy3731 atoy3731 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zackbradys zackbradys changed the title added integration tests for tarballs added integration tests for non hauler tarballs Sep 25, 2024
@zackbradys zackbradys requested review from a team and atoy3731 September 26, 2024 16:12
@zackbradys zackbradys merged commit 8a53a26 into hauler-dev:main Sep 27, 2024
2 checks passed
@zackbradys zackbradys deleted the testing-updates-for-tarballs branch September 27, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amartin120 amartin120 amartin120 approved these changes

@atoy3731 atoy3731 Awaiting requested review from atoy3731

Assignees

@zackbradys zackbradys

Labels
enhancement New feature or request size/S Denotes an issue/PR requiring a relatively small amount of work
Projects
Hauler
Status: Resolved
Milestone
Hauler v1.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@zackbradys @atoy3731 @amartin120 @dweomer