Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

have extract use proper ref from store info #335

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

amartin120
Copy link
Contributor

@amartin120 amartin120 commented Oct 1, 2024

Please check below, if the PR fulfills these requirements:

  • Commit(s) and code follow the repositories guidelines.
  • Test(s) have been added or updated to support these change(s).
  • Doc(s) have been added or updated to support these change(s).

Associated Links:

Types of Changes:

  • bugfix

Proposed Changes:

  • Now that images so the origin registry in hauler store info, hauler store extract wasn't expecting the registry to be specified.

Verification/Testing of Changes:

  • tested extract with registry and without.
hauler store extract rgcrprod.azurecr.us/busybox:latest 

and

hauler_darwin_arm64/hauler store extract busybox:latest 

and

hauler_darwin_arm64/hauler store extract hauler/busybox:latest  

Additional Context:

Signed-off-by: Adam Martin <adam.martin@ranchergovernment.com>
@amartin120 amartin120 requested a review from zackbradys October 1, 2024 19:25
@zackbradys zackbradys added bug Something isn't working enhancement New feature or request size/S Denotes an issue/PR requiring a relatively small amount of work labels Oct 1, 2024
@zackbradys zackbradys added this to the Hauler v1.1.0 milestone Oct 1, 2024
Copy link
Member

@zackbradys zackbradys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zackbradys zackbradys merged commit 9f7229a into hauler-dev:main Oct 1, 2024
2 checks passed
@amartin120 amartin120 deleted the update-extract branch February 7, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request size/S Denotes an issue/PR requiring a relatively small amount of work
Projects
Status: Resolved
Development

Successfully merging this pull request may close these issues.

2 participants