Consider import * to be an explicit re-export

Resolves python#11856
hauntsaninja · Dec 29, 2021 · ee0e30f · ee0e30f
1 parent 3d20576
commit ee0e30f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 18 deletions.
diff --git a/mypy/semanal.py b/mypy/semanal.py
@@ -2037,12 +2037,10 @@ def visit_import_all(self, i: ImportAll) -> None:
                         if self.process_import_over_existing_name(
                                 name, existing_symbol, node, i):
                             continue
-                    # In stub files, `from x import *` always reexports the symbols.
-                    # In regular files, only if implicit reexports are enabled.
-                    module_public = self.is_stub_file or self.options.implicit_reexport
+                    # `from x import *` always reexports symbols
                     self.add_imported_symbol(name, node, i,
-                                             module_public=module_public,
-                                             module_hidden=not module_public)
+                                             module_public=True,
+                                             module_hidden=False)
 
         else:
             # Don't add any dummy symbols for 'from x import *' if 'x' is unknown.

diff --git a/test-data/unit/check-flags.test b/test-data/unit/check-flags.test
@@ -1562,17 +1562,7 @@ __all__ = ('b',)
 [out]
 main:2: error: Module "other_module_2" does not explicitly export attribute "a"; implicit reexport disabled
 
-[case testNoImplicitReexportStarConsideredImplicit]
-# flags: --no-implicit-reexport
-from other_module_2 import a
-[file other_module_1.py]
-a = 5
-[file other_module_2.py]
-from other_module_1 import *
-[out]
-main:2: error: Module "other_module_2" does not explicitly export attribute "a"; implicit reexport disabled
-
-[case testNoImplicitReexportStarCanBeReexportedWithAll]
+[case testNoImplicitReexportStarConsideredExplicit]
 # flags: --no-implicit-reexport
 from other_module_2 import a
 from other_module_2 import b
@@ -1583,8 +1573,6 @@ b = 6
 from other_module_1 import *
 __all__ = ('b',)
 [builtins fixtures/tuple.pyi]
-[out]
-main:2: error: Module "other_module_2" does not explicitly export attribute "a"; implicit reexport disabled
 
 [case testNoImplicitReexportGetAttr]
 # flags: --no-implicit-reexport --python-version 3.7