Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows support for mypy_primer --coverage #110

Merged
merged 4 commits into from
Nov 27, 2023

Conversation

A5rocks
Copy link
Contributor

@A5rocks A5rocks commented Nov 26, 2023

This makes mypy_primer --coverage run without errors... though the output is wrong:

Checking 131 projects...
Containing 0 files...
Totalling to 0 lines...

Good enough.

@A5rocks A5rocks changed the title Fix windows support Fix windows support for mypy_primer --coverage Nov 26, 2023
Comment on lines 146 to 148
pip_cmd="{pip} install aiohttp uvloop pycryptodome",
expected_mypy_success=True,
only_platform="linux",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this be fine?:

Suggested change
pip_cmd="{pip} install aiohttp uvloop pycryptodome",
expected_mypy_success=True,
only_platform="linux",
pip_cmd="{pip} install aiohttp pycryptodome",
expected_mypy_success=True,

hauntsaninja and others added 2 commits November 26, 2023 17:13

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Owner

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I pushed a change to allow multiple platforms / allow these to run on Mac. If it looks good to you, I'll merge

@A5rocks
Copy link
Contributor Author

A5rocks commented Nov 27, 2023

Yeah looks good

@hauntsaninja hauntsaninja merged commit b22bd76 into hauntsaninja:master Nov 27, 2023
1 check passed
@A5rocks A5rocks deleted the fix-windows-support branch November 27, 2023 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants