-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add jsonschema libs #35
Conversation
Synapse devs noted an issue with types-jsonschema as types are being introduced to the barebones stubs in typeshed. Checking against their usage also seems to cover a bunch of other libraries in typeshed.
Thanks for the heads-up! No objections from us, but I would like to sound a few notes of caution:
|
Co-authored-by: David Robertson <david.m.robertson1@gmail.com>
I think that it's okay that not everything inside the library is annotated, so long as it passes More importantly, I saw that you're using a bunch of different stubs from typeshed. IMO, that makes the project a sort of attractive option to include, since it covers many different parts of typeshed, even if it only uses each one a little.
This seems to me like the biggest likely issue. I'll wait to hear from maintainers about this, but I probably wouldn't have suggested the integration if I'd known that there's an internal plugin. The internal plugin in particular could make Everything else seems pretty much okay to me. I see a commented out block where one project was listed as pulling the |
See #8 for discussion of plugins. But I think it's fine if mypy-primer projects get some mypy errors: what matters is that they give us useful information if something changes. |
This repo uses mypy plugins including a custom, internal plugin. As such, it isn't suitable for testing under mypy_primer until/unless plugin handling is added.
I removed I've started looking for other projects using |
Thanks! I will one day get around to adding support for plugins :-) |
I'm adding more info to
types-jsonschema
stubs, and there were two bugs which it would have been nice to catch earlier. Add two users oftypes-jsonschema
to the project list.check-jsonschema
(my own work)synapse
, who reported and submitted a fix for atypes-jsonschema
bug@DMRobertson, I don't believe that adding your project to mypy_primer carries any obligation for you or your team, but wanted to give you a heads-up about this.
We can also cut
synapse
and just addcheck-jsonschema
if adding it is an issue for someone.